[PATCH] clk: handle NULL args in clk_set_parent()

Bastian Krause bst at pengutronix.de
Thu May 12 01:54:37 PDT 2022


Hi Sascha,

On 5/12/22 09:03, Sascha Hauer wrote:
> On Wed, May 11, 2022 at 12:09:11PM +0200, Bastian Krause wrote:
>> NULL struct clk pointers should be treated just as the Linux kernel clk
>> driver does [1]. The reasoning should also apply to the parent clk
>> argument.
>>
>> A NULL struct clk pointer can happen for example on the Freescale i.MX6
>> SABRE Smart Device Board if CONFIG_DRIVER_VIDEO_IMX_IPUV3 is disabled,
>> leading to assigned-clocks IMX6QDL_CLK_LDB_DI0_SEL and
>> IMX6QDL_CLK_LDB_DI1_SEL [2] being unavailable. Without this patch, the
>> board hangs while setting those assigned clock configurations since [3].
>>
>> [1] 89ac8d7ae1cd ("clk: handle NULL struct clk gracefully")
>> [2] dts/src/arm/imx6qdl-sabresd.dtsi
>> [3] f5eb5fddb4 ("clk: fix of clk set defaults when dev is a clk provider")
>>
>> Signed-off-by: Bastian Krause <bst at pengutronix.de>
>> ---
>>   drivers/clk/clk.c | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> Applied, thanks

Did you see the v2 of this patch?

Regards,
Bastian

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list