[PATCH] GPIO: clps711x: Simplify initialization

Sascha Hauer sha at pengutronix.de
Tue Apr 19 23:46:02 PDT 2022


On Tue, Apr 19, 2022 at 12:36:06PM +0300, Alexander Shiyan wrote:
> Signed-off-by: Alexander Shiyan <eagle.alexander923 at gmail.com>
> ---
>  drivers/gpio/gpio-clps711x.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/gpio/gpio-clps711x.c b/drivers/gpio/gpio-clps711x.c
> index 67bce79bc3..a1965b33e4 100644
> --- a/drivers/gpio/gpio-clps711x.c
> +++ b/drivers/gpio/gpio-clps711x.c
> @@ -25,17 +25,15 @@ static int clps711x_gpio_probe(struct device_d *dev)
>  		return PTR_ERR(iores);
>  	dat = IOMEM(iores->start);
>  
> +	iores = dev_request_mem_resource(dev, 1);
> +	if (IS_ERR(iores))
> +		return PTR_ERR(iores);
> +
>  	switch (id) {
>  	case 3:
> -		iores = dev_request_mem_resource(dev, 1);
> -		if (IS_ERR(iores))
> -			return PTR_ERR(iores);
>  		dir_inv = IOMEM(iores->start);
>  		break;
>  	default:
> -		iores = dev_request_mem_resource(dev, 1);
> -		if (IS_ERR(iores))
> -			return PTR_ERR(iores);
>  		dir = IOMEM(iores->start);
>  		break;
>  	}
> -- 
> 2.32.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list