[PATCH 05/25] console: Fix message colours
jmaselbas at kalray.eu
Fri Dec 17 05:24:36 PST 2021
On Fri, Dec 17, 2021 at 02:23:29PM +0100, Sascha Hauer wrote:
> Hi Jules,
> On Thu, Dec 16, 2021 at 01:21:25PM +0100, Jules Maselbas wrote:
> > Hi,
> > On Mon, Dec 13, 2021 at 10:08:45PM +0100, Sascha Hauer wrote:
> > > The correct code to change colours is "\033[1;31m", not "\033[31m". Fix
> > > that.
> > Uhmm I am curious why this is the "correct" way. From what I can tell
> > the terminfo for me says that 'setaf' red is '\e[31m'.
> > Maybe the EFI consol doesn't support setaf "termcap", an only has the
> > 'sgr' capability, and the non-bold red selected as '\e[0;31m'.
> Looking again at it, '\e[31m' is correct. Maybe it would have been
> better to say "Change to what efi-stdio can parse"
yeah, this is a nitpick
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
> To declare a filtering error, please use the following link : https://www.security-mail.net/reporter.php?mid=f35c.61bc8f52.89ac3.0&r=jmaselbas%40kalray.eu&s=sha%40pengutronix.de&o=Re%3A+%5BPATCH+05%2F25%5D+console%3A+Fix+message+colours&verdict=C&c=5c80bcf023a7e05c839c2ae283528cd6185478a1
More information about the barebox