[PATCH] ARM: AT91: Add skov-arm9cpu board support

[Sascha Hauer]

On Wed, Apr 14, 2021 at 02:45:55PM +0200, Ahmad Fatoum wrote:
> Hi,
> 
> > +ENTRY_FUNCTION(start_skov_arm9cpu, r0, r1, r2)
> > +{
> > +	void *fdt;
> > +
> > +	arm_cpu_lowlevel_init();
> > +
> > +	arm_setup_stack(AT91SAM9263_SRAM0_BASE + AT91SAM9263_SRAM0_SIZE - 16);
> 
> See 6b3dc4abd884e7 ("ARM: Cleanup stack offset cargo cult"). Likely, the - 16
> here can go away too.

Fixed.

> > +			device-path = &environment_nor;
> > +		};
> > +	};
> > +
> > +	ahb {
> > +		apb {
> 
> &{/ahb/apb/...} please. Otherwise, if upstream eventually renames the busses
> to generic names (like what's happening to other SoCs), we don't get silently
> broken. See https://barebox.org/doc/latest/devicetree/index.html#barebox-device-trees
> 
> I know that most at91 device trees look like this, but the trend seems to suggest
> that at one time, they will be changed for upstream device trees. (Unless the
> maintainers said otherwise?).

Fixed before applying.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |