[PATCH v3 3/3] sandbox: add i2c and spi libftdi1 bit-bang example

[Sascha Hauer]

On Mon, Jan 22, 2018 at 12:59:18PM +0300, Antony Pavlov wrote:
> Make necessary changes in sandbox_defconfig:
> enable gpio, spi, i2c and led stuff.
> 
> Usage:
> 
>   barebox$ make sandbox_defconfig
>   barebox$ sed -i "s/# CONFIG_GPIO_LIBFTDI1.*$/CONFIG_GPIO_LIBFTDI1=y/" .config
> 
>   # edit arch/sandbox/dts/sandbox-libftdi-example.dtsi
> 
>   barebox$ echo '#include "sandbox-libftdi-example.dtsi"' >> arch/sandbox/dts/sandbox.dts
>   barebox$ make
>   barebox$ sudo ./barebox -d arch/sandbox/dts/sandbox.dtb
> 
> Signed-off-by: Antony Pavlov <antonynpavlov at gmail.com>
> ---
>  arch/sandbox/configs/sandbox_defconfig        | 21 ++++++-
>  arch/sandbox/dts/sandbox-libftdi-example.dtsi | 80 +++++++++++++++++++++++++++
>  2 files changed, 100 insertions(+), 1 deletion(-)
> 
> +++ b/arch/sandbox/dts/sandbox-libftdi-example.dtsi
> @@ -0,0 +1,80 @@
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> +	gpio0: gpio at 0 {
> +		compatible = "barebox,libftdi1-gpio";
> +		usb,id_vendor = <0x0403>;
> +		usb,id_product = <0x6010>;
> +
> +		/*
> +		 * The serial number can be used to select
> +		 * a specific device in case more than
> +		 * one is connected to the host.
> +		 */
> +		/* usb,i_serial_number = "20180120"; */
> +
> +		/* use ACBUS[7:0] */
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +
> +		status = "okay";
> +	};
> +
> +	spi0: spi0 {
> +		compatible = "spi-gpio";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		gpio-sck  = <&gpio0 0 GPIO_ACTIVE_HIGH>;
> +		gpio-mosi = <&gpio0 1 GPIO_ACTIVE_HIGH>;
> +		gpio-miso = <&gpio0 2 GPIO_ACTIVE_HIGH>;
> +		cs-gpios  = <&gpio0 3 GPIO_ACTIVE_HIGH>;
> +
> +		num-chipselects = <1>;
> +
> +		status = "disabled";

Given that this is an example which is not used unless you include it
manually I think you can remove the status properties.

Otherwise this series looks fine to me. I can remove the properties
while applying if you like.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |