[PATCH] OMAP_GPMC: this driver depends on MTD

Sascha Hauer s.hauer at pengutronix.de
Mon Oct 16 01:34:22 PDT 2017


Hi Jürgen,

On Mon, Oct 16, 2017 at 10:01:46AM +0200, Juergen Borleis wrote:
> Otherwise it fails with:
> 
> drivers/bus/omap-gpmc.c:498: undefined reference to `of_get_nand_bus_width'
> 
> Signed-off-by: Juergen Borleis <jbe at pengutronix.de>

I would prefer a

	if (IS_ENABLED(CONFIG_MTD) && !strncmp(child->name, "nand", 4))
		ret = gpmc_probe_nand_child(dev, child);

That would allow to use the GPMC without MTD support which is a valid
usecase if for example only a network device is connected.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list