[PATCH 06/21] net: dhcp: Do not overwrite serverip if it is valid

Sam Ravnborg sam at ravnborg.org
Sat Nov 25 08:36:23 PST 2017


Hi Sasha.

>  }
>  
> -void net_set_serverip(IPaddr_t ip)
> +void net_set_serverip(IPaddr_t ip, bool overwrite)
>  {
> +	if (net_serverip && !overwrite)
> +		return;
> +
>  	net_serverip = ip;
>  }

An alternative solution had been to implement two functions:
net_set_serverip() - that would always set the ip.
net_set_empty_serverip() - update ip only if empty

This is more readable than a boolean flag which
you always need to look up to check the interpretation of.

	Sam



More information about the barebox mailing list