[PATCH] clk: i.MX51: Add missing USBOH3_GATE clock

Nikita Yushchenko nikita.yoush at cogentembedded.com
Mon May 22 22:42:09 PDT 2017


>  static void mx5_clocks_mx51_mx53_init(void __iomem *base)
> @@ -392,6 +394,12 @@ int __init mx51_clocks_init(struct device_d *dev, void __iomem *regs)
>  	clkdev_add_physbase(clks[IMX5_CLK_PER_ROOT], MX51_PWM1_BASE_ADDR, "per");
>  	clkdev_add_physbase(clks[IMX5_CLK_PER_ROOT], MX51_PWM2_BASE_ADDR, "per");
>  
> +	clkdev_add_physbase(clks[IMX5_CLK_USBOH3_GATE], MX51_OTG_BASE_ADDR + 0x000, NULL);
> +	clkdev_add_physbase(clks[IMX5_CLK_USBOH3_GATE], MX51_OTG_BASE_ADDR + 0x200, NULL);
> +	clkdev_add_physbase(clks[IMX5_CLK_USBOH3_GATE], MX51_OTG_BASE_ADDR + 0x400, NULL);
> +	clkdev_add_physbase(clks[IMX5_CLK_USBOH3_GATE], MX51_OTG_BASE_ADDR + 0x600, NULL);
> +	clkdev_add_physbase(clks[IMX5_CLK_USBOH3_GATE], MX51_OTG_BASE_ADDR + 0x800, NULL);
> +
>  	if (IS_ENABLED(CONFIG_DRIVER_VIDEO_IMX_IPUV3))
>  		mx51_clocks_ipu_init(regs);

It may be cleaner to setup USB related clocks under
if (IS_ENABLED(CONFIG_...) { ... }  - i.e. in the same way as IPU
related clocks are added in neighbour line.

Also, this is the only place in this file where address arithmetic is
used.  Not sure if this is ok or not but it catches eye.

Nikita



More information about the barebox mailing list