[PATCH 2/3] mci: imx-esdhc: add DSR support

[Markus Niebel]

Hello,
> Hello.
> 
> Пятница, 10 января 2014, 10:29 +01:00 от Markus Niebel <list-09_barebox at tqsc.de>:
>> From: Markus Niebel <Markus.Niebel at tqs.de>
>>
>> having DSR support in mci-core we need a way to
>> forward the DSR value to the driver. Add it to
>> platform data for imx-esdhc
> ...
>> diff --git a/drivers/mci/imx-esdhc.c b/drivers/mci/imx-esdhc.c
>> index 7664e7b..deb44b0 100644
>> --- a/drivers/mci/imx-esdhc.c
>> +++ b/drivers/mci/imx-esdhc.c
>> @@ -582,6 +582,8 @@ static int fsl_esdhc_probe(struct device_d *dev)
>>  	if (host->mci.f_min < 200000)
>>  		host->mci.f_min = 200000;
>>  	host->mci.f_max = rate;
>> +	host->mci.use_dsr = pdata->use_dsr;
>> +	host->mci.dsr_val = pdata->dsr_val;
> 
> What happen if device is probed from devicetree?
Thanks for pointing this out. 

As the cover says - just a RFC. We have working code for device tree under linux here.
My proposal is to pass the DSR value as an optional property to the host controller - 
then it could be parsed by mci_of_parse - but this needs to be in sync with the kernel.
Yes and the setting from pdata should be optional - since pdata is NULL in case of device tree.

Will collect comments and prepare a second round.

Markus
> 
> ---
>