[PATCH 0/7] Basic support for Marvell Armada 370/XP SoC

[Thomas Petazzoni]

Dear Jason Cooper,

On Sat, 4 May 2013 13:15:30 -0400, Jason Cooper wrote:

> Great work!  Very clean series.  I only have one thought.  Prafulla
> (u-boot kirkwood maintainer) is always asking about consolidating the
> kwbimage.cfg files.  The three you've submitted for the first three
> boards are almost (if not entirely) identical.  Before a whole bunch of
> boards get added, should we make a kwbimage-common.cfg or similar?

I'm not sure I want to make the configuration language more complicated
than it is already. It's already a pain to parse such a configuration
file in C (I would have preferred to write the kwbimage tool in Python,
but since all existing Barebox tools are in C, I wasn't sure a Python
tool would have been accepted). Adding the support for includes means
that you have to recursively handle includes, etc. I'm not sure I want
to go down this road for files that typically have between 10 to 30
lines.

> I'm not sold on the idea, I'm just mentioning it since it's been an
> issue in the past.  If we want to do that, now would be the time.

I don't agree: we can refactor those files at any point in time. For
now, I don't think it's very useful, but in the future, if it turns out
to be useful and someone feels that it is important to improve this, we
can always refactor the .cfg files.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com