[PATCH 3/5] GPIO: i.MX: Rewrite driver for using generic GPIO code

[Sascha Hauer]

On Sat, Apr 20, 2013 at 08:18:50AM +0400, Alexander Shiyan wrote:
> 
> Signed-off-by: Alexander Shiyan <shc_work at mail.ru>
> ---
>  arch/arm/Kconfig        |   1 -
>  drivers/gpio/Kconfig    |   1 +
>  drivers/gpio/gpio-imx.c | 125 ++++++++++++------------------------------------
>  3 files changed, 31 insertions(+), 96 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index bb9b47b..5607754 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -72,7 +72,6 @@ config ARCH_HIGHBANK
>  
>  config ARCH_IMX
>  	bool "Freescale iMX-based"
> -	select GENERIC_GPIO
>  	select GPIOLIB
>  	select COMMON_CLK
>  	select CLKDEV_LOOKUP
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 74a4baa..5ccd35b 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -29,6 +29,7 @@ config GPIO_GENERIC_PLATFORM
>  
>  config GPIO_IMX
>  	def_bool ARCH_IMX
> +	select GPIO_GENERIC

I'm not convinced by this change. Indeed this makes for smaller
sourcecode, but the binary gets over 1kb bigger. I think this is too
much for no additional gain.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |