[PATCH 1/2] drivers gpio: Check for negativ gpio values

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Mon Sep 24 05:34:08 EDT 2012


On 11:16 Mon 24 Sep     , Jan Lübbe wrote:
> On Mon, 2012-09-24 at 10:59 +0200, Teresa Gámez wrote:
> >  static int gpio_is_valid(unsigned gpio)
> >  {
> > -	if (gpio < ARCH_NR_GPIOS)
> > +	if (gpio < ARCH_NR_GPIOS && gpio >= 0)
> 
> For an 'unsigned gpio', gpio >= 0 is always true.
unsigned is wrong type gpio need to int

Best Regards,
J.



More information about the barebox mailing list