[PATCH 0/2] Y-Modem implementation change

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Thu Nov 1 13:50:49 EDT 2012


On 18:37 Thu 01 Nov     , Robert Jarzmik wrote:
> Hi everyone,
> 
> This patchset aims at changing the Y-Modem protocol implementation.
> You have already seen the RFC version, this is the next version, which :
>  - provides a much more tested version
>  - is ready for review
> 
> The following comments have been taken into account :
>  - Antony: testing on a serial line
>  - Sascha: split between protocol and commands
>  - Jean-Christophe: kermit protocol change
> 
> So before doing the real review, could I ask of you :
>  - Antony: could you redo your test over a serial line by applying only
>            the first patch so that you can compare loady and loady2 ?
>            Don't use "loady2 -g", as Y-Modem/G protocol requires a 
>            lossless line (USB), and a serial line cannot guarantee it.
>  - Sascha: does the split command/protocol suit you ?
>  - Jean-Christophe: I left the loadb implementation as it is. The goal
>                     of the patch is to change X-Modem and Y-Modem(G)
>                     implementation, not kermit. Could you test that I
>                     have not created a regression of loadb ?

I'll prefer to have a new command named xyz so we have no confusion between
loadb and the new one

Best Regards,
J.



More information about the barebox mailing list