[PATCH 2/7] mfd: add mc34708 driver

[Jean-Christophe PLAGNIOL-VILLARD]

On 14:22 Tue 21 Feb     , Eric Bénard wrote:
> Le Tue, 21 Feb 2012 14:03:18 +0100,
> Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com> a écrit :
> 
> > On 08:03 Tue 21 Feb     , Eric Bénard wrote:
> > > Le Tue, 21 Feb 2012 04:48:35 +0100,
> > > Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com> a écrit :
> > > 
> > > > > +static struct mc34708 *mc_dev;
> > > > > +
> > > > > +struct mc34708 *mc34708_get(void)
> > > > > +{
> > > > > +	if (!mc_dev)
> > > > > +		return NULL;
> > > > > +
> > > > > +	return mc_dev;
> > > > > +}
> > > > > +EXPORT_SYMBOL(mc34708_get);
> > > > no please do not export the current as it will not alloe multiple chip on
> > > > board
> > > you can't have more than one of this chip on the board connected to 
> > > the same CPU.
> > except if you have 2 soc on the same board
> > 
> that's why I said "connected to the same CPU".
> If you have 2 SOC, each SOC will have its own PMIC thus it's own
> barebox, thus no problem.
> 
> > here you use it to detect the presence of the device where we can detect it by
> > the presence of the dev file
> 
> in the future we will also use that to write to the PMIC (as done on
> mx35-3stack for example).
I still don't like the idea to export it

You need a proper API to manage the PMIC

so for today no need of this and I doubt the API will need it

Best Regards,
J.