"make distclean" doesn't remove generated MLO file

[Premi, Sanjeev]

> -----Original Message-----
> From: Robert P. J. Day [mailto:rpjday at crashcourse.ca] 
> Sent: Tuesday, February 07, 2012 10:15 PM
> To: Premi, Sanjeev
> Cc: U-Boot Version 2 (barebox)
> Subject: RE: "make distclean" doesn't remove generated MLO file
> 
> On Tue, 7 Feb 2012, Premi, Sanjeev wrote:
> 
> > This patch should help.
> > If you confirm, I can submit it formally.
> >
> > ~sanjeev
> >
> > >From 072ef5dd7022877fc1470b6dc14a0ec309eb68a0 Mon Sep 17 
> 00:00:00 2001
> > From: Sanjeev Premi <premi at ti.com>
> > Date: Tue, 7 Feb 2012 21:58:50 +0530
> > Subject: [PATCH] omap: Remove MLO with distclean
> >
> >
> > Signed-off-by: Sanjeev Premi <premi at ti.com>
> > ---
> >  Makefile |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 5cf49da..5a03b32 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1008,7 +1008,7 @@ MRPROPER_DIRS  += include/config 
> include2 usr/include
> >  MRPROPER_FILES += .config .config.old include/asm .version 
> .old_version \
> >                    include/generated/autoconf.h 
> include/generated/version.h      \
> >                    include/generated/utsrelease.h 
> include/config.h           \
> > -		  Module.symvers tags TAGS cscope*
> > +		  Module.symvers tags TAGS cscope* MLO
> >
> >  # clean - Delete most, but leave enough to build external modules
> >  #
> 
>   based on this from the Makefile:
> 
> ===== snip =====
> 
> # Directories & files removed with 'make clean'
> CLEAN_DIRS  += $(MODVERDIR)
> CLEAN_FILES +=  barebox System.map
> include/generated/barebox_default_env.h \
>                 .tmp_version .tmp_barebox* barebox.bin barebox.S \
>                 .tmp_kallsyms* barebox_default_env barebox.ldr
> Doxyfile.version
> 
> # Directories & files removed with 'make mrproper'
> MRPROPER_DIRS  += include/config include2 usr/include
> MRPROPER_FILES += .config .config.old include/asm .version
> .old_version \
>                   include/generated/autoconf.h 
> include/generated/version.h      \
>                   include/generated/utsrelease.h 
> include/config.h           \
>                   Module.symvers tags TAGS cscope* MLO
> 
> ===== snip =====
> 
>   i would think that it should be added to CLEAN_FILES, given its
> relation to barebox.bin, etc.  but either way will certainly work.
> 

I usually compile both stages together with a 'make clean' in
between, hence decided to preserve MLO. Makes it easy to copy
both MLO and barebox.bin at same time.

Otherwise, yes, MLO goes better with CLEAN_FILES.

~sanjeev