[PATCH 1/2] fs: move dev_add_child before device_register
Sascha Hauer
s.hauer at pengutronix.de
Wed Dec 12 09:07:50 EST 2012
Biology tells us that the parent is known before the child is born.
Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
---
fs/fs.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/fs.c b/fs/fs.c
index dc3a6e3..4c8c61a 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -1107,11 +1107,6 @@ static int fs_probe(struct device_d *dev)
if (ret)
return ret;
- if (fsdev->cdev) {
- dev_add_child(fsdev->cdev->dev, &fsdev->dev);
- fsdev->parent_device = fsdev->cdev->dev;
- }
-
fsdev->driver = fsdrv;
list_add_tail(&fsdev->list, &fs_device_list);
@@ -1231,6 +1226,11 @@ int mount(const char *device, const char *fsname, const char *_path)
if (!strncmp(device, "/dev/", 5))
fsdev->cdev = cdev_by_name(device + 5);
+ if (fsdev->cdev) {
+ dev_add_child(fsdev->cdev->dev, &fsdev->dev);
+ fsdev->parent_device = fsdev->cdev->dev;
+ }
+
ret = register_device(&fsdev->dev);
if (ret)
goto err_register;
--
1.7.10.4
More information about the barebox
mailing list