[RFC 0/2] clk: pass the 'flags' parameter to clk_fixed()

Sascha Hauer s.hauer at pengutronix.de
Thu Dec 6 08:44:13 EST 2012


Hi Antony,

On Thu, Dec 06, 2012 at 12:25:34PM +0400, Antony Pavlov wrote:
> The 'flags' parameter make possible creation
> of a 'CLK_ALWAYS_ENABLED' clock without code overhead.
> 
> So it is possible to create clock this way
>  clk_fixed("main_clock", 24000000, 0);
> or that way
>  clk_fixed("main_clock", 24000000, CLK_ALWAYS_ENABLED);
> 
> I can't check my clk_fixed-related changes for ARM-based
> boards, so please consider, do we need CLK_ALWAYS_ENABLED
> in the patch '[RFC 2/2]' or we need '0'.

Nice move to be able to pass the flags to clk_fixed. For this special
clock and flag we won't need it though: The fixed clock by definition
always is enabled. We should rather set this flag unconditionally for
them.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list