[PATCH 2/2] mtd core: call driver write function with complete buffer

Robert Jarzmik robert.jarzmik at free.fr
Mon Dec 3 14:10:08 EST 2012


Sascha Hauer <s.hauer at pengutronix.de> writes:

> mtd->write is supposed to loop around pages internally, no need
> to do this in mtd_write. This fixes a huge write performance drop
> with the m25p80 driver when it was converted to a mtd driver recently.
> Since mtd->writesize is 1 for this driver mtd_write ended up doing
> single byte writes on the flash.

Both patches look good to me.
Of course they change a bit the behaviour, as previously mtd_write() was
skipping "all 0xff" pages writes, and it doesn't do it anymore. But I don't see
any negative impact out of my head here.

As they are already in -next, no need for an Acked-by :)

Cheers.

--
Robert



More information about the barebox mailing list