[PATCH 17/18] UBIFS: Improve error message when reading superblock failed

Renaud Barbier renaud.barbier at ge.com
Mon Dec 3 13:08:33 EST 2012


From: Bernhard Walle <walle at corscience.de>

In addition to the error message also display the error code. I had the
problem that my malloc memory was not enough (ENOMEM), and if u-boot
had displayed the error code immediately that would have saved me some
debugging.

Signed-off-by: Bernhard Walle <walle at corscience.de>

Use ubifs_err instead of printf.
Add "errno=%d" in output as suggested by Albert Aribaud.

Signed-off-by: Thomas Weber <weber at corscience.de>

Use priv->vol_name instead of "name".

Signed-off-by: Renaud Barbier <renaud.barbier at ge.com>
---
 fs/ubifs/super.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 118d728..a77b73a 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -1189,8 +1189,8 @@ int ubifs_mount(struct ubifs_priv *priv)
 	mnt = NULL;
 	ret = ubifs_get_sb(&ubifs_fs_type, flags, priv->vol_name, data, mnt);
 	if (ret) {
-		printf("Error reading superblock on volume '%s'!\n",
-				priv->vol_name);
+		ubifs_err("Error reading superblock on volume '%s' errno=%d!\n",
+				priv->vol_name, ret);
 		return -1;
 	}
 
-- 
1.7.1




More information about the barebox mailing list