[PATCH] Generic environment: Fix assembling of the 'mtdparts' variable

Juergen Beisert jbe at pengutronix.de
Tue Feb 15 08:49:32 EST 2011


The semicolon is a delimiter, not an end marker. With a trailing semicolon the
kernel give the confusing message:

mtd: no mtd-id

With this patch, a semicolon gets added on demand only.

Signed-off-by: Juergen Beisert <jbe at pengutronix.de>

---
 defaultenv/bin/boot |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Index: barebox-2011.01.0/defaultenv/bin/boot
===================================================================
--- barebox-2011.01.0.orig/defaultenv/bin/boot
+++ barebox-2011.01.0/defaultenv/bin/boot
@@ -43,11 +43,14 @@ else
 fi
 
 if [ -n $nor_parts ]; then
-	mtdparts="${mtdparts}physmap-flash.0:${nor_parts};"
+	mtdparts="${mtdparts}physmap-flash.0:${nor_parts}"
 fi
 
 if [ -n $nand_parts ]; then
-	mtdparts="${mtdparts}${nand_device}:${nand_parts};"
+	if [ -n ${mtdparts} ]; then
+		mtdparts="${mtdparts};"
+	fi
+	mtdparts="${mtdparts}${nand_device}:${nand_parts}"
 fi
 
 if [ -n $mtdparts ]; then

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | Phone: +49-8766-939 228     |
Vertretung Sued/Muenchen, Germany             | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686              | http://www.pengutronix.de/  |



More information about the barebox mailing list