[PATCH V3 2/8] drivers/mtd: cosmetic changes

Robert Jarzmik robert.jarzmik at free.fr
Wed Dec 21 16:27:40 EST 2011


Sascha Hauer <s.hauer at pengutronix.de> writes:

>> -#ifdef CONFIG_NAND_OOB_DEVICE
>> -static ssize_t nand_read_oob(struct cdev *cdev, void *buf, size_t count, ulong offset, ulong flags)
>> +#ifdef CONFIG_NAND_READ_DEVICE
>> +static ssize_t nand_read_oob(struct cdev *cdev, void *buf, size_t count,
>> +			     ulong offset, ulong flags)
>
> You change the name of the Kconfig variable here. This shouldn't be here
> and breaks read_oob support.
True, but that was eliminated by a further patch (split of main mtd device from
oob device). Still, I removed that hunk for V4.

Cheers.

-- 
Robert



More information about the barebox mailing list