[PATCH V2 3/8] drivers/mtd: transfer NAND notions to MTD core

Robert Jarzmik robert.jarzmik at free.fr
Mon Dec 19 05:48:49 EST 2011


Sascha Hauer <s.hauer at pengutronix.de> writes:

> On Fri, Dec 16, 2011 at 10:50:29PM +0100, Robert Jarzmik wrote:
>
>>  
>>  if MTD
>>
>> +config MTD_WRITE
>> +	bool
>> +	default y
>> +	prompt "Support writing to MTD devices"
>> +
>> +config MTD_READ_OOB
>> +	bool
>> +	default y
>> +	prompt "Create a device for reading the OOB data"
>> +
>
> This one is a rename...
>
>>  
>> -config NAND_READ_OOB
>> -	bool
>> -	default y
>> -	prompt "create a device for reading the OOB data"
>> -
>
> from this one, but not all references to it were renamed.
Arg. I see it now. I'll amend this patch.

> This revealed a bug which was present before this patch. The following
> fixes this, see the commit log for more details. Can you rebase your
> series on this patch?
Of course.

> Otherwise your series seems to work properly.
Ok, great. Do you want me to resend the whole serie, or provide you a pull
request with this patchset rebased on barebox.git/next, and your patch, and then
this serie ?

FWIW, I checked erase/read/write on mtdraw and mtd, and with the docg3
everything works fine. If I understand correctly, you tested with a NAND you've
got, which is great as a non-regression test :)

Cheers.

-- 
Robert



More information about the barebox mailing list