[PATCH v2] defaultenv: use a compressed version when embedded in barebox

[Sascha Hauer]

On Wed, Dec 14, 2011 at 06:47:21PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> with using gzip and the default env we can save 5.2KiB (5,352 bytes)
> 
> tested on sam9g20ek
> before
> -rwxr-xr-x  1 root root 265748 Dec 14 00:42 barebox.bin
> after
> -rwxr-xr-x  1 root root 260396 Dec 14 00:42 barebox.bin
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
> v2:
> 
> 	fix the comment

Appearently you haven't read my mail. So to repeat myself:

> zlib is bigger than the uncompressed defaultenv.

This means that this step is only worth doing when zlib is selected
anyway. Otherwise you end up with 5Kb more: 10Kb zlib binary space + 3Kb
compressed env is bigger than 8Kb uncompressed defaultenv.

So my suggestion was:

> How about a
> config DEFAULT_ENVIRONMENT_COMPRESSED
>         default y if ZLIB
> instead?


>  
> -include/generated/barebox_default_env.h: barebox_default_env
> +barebox_default_env.gz: barebox_default_env FORCE

And also I asked:

> Do we need this FORCE? It triggers a new build everytime even when
> nothing has changed.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |