[PATCH] Fix a data abort with fec_imx
Sascha Hauer
s.hauer at pengutronix.de
Mon Jan 11 12:58:35 EST 2010
On Mon, Jan 11, 2010 at 03:32:15PM +0100, Eric Benard wrote:
> From: Eric Benard <ebenard at 1720eb.(none)>
>
> edev was allocated using malloc. On one board (NOR boot), we met data abort
> in eth_register (at dev_add_param(dev, &edev->param_ip);).
> Allocating edev with xzalloc (as in several other drivers) fixed the problem.
Ok, applied.
Sascha
>
> Signed-off-by: Eric Benard <eric at eukrea.com>
> ---
> drivers/net/fec_imx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/fec_imx.c b/drivers/net/fec_imx.c
> index 4893291..49140e7 100644
> --- a/drivers/net/fec_imx.c
> +++ b/drivers/net/fec_imx.c
> @@ -542,7 +542,7 @@ static int fec_probe(struct device_d *dev)
> #ifdef CONFIG_ARCH_IMX27
> PCCR0 |= PCCR0_FEC_EN;
> #endif
> - edev = (struct eth_device *)malloc(sizeof(struct eth_device));
> + edev = (struct eth_device *)xzalloc(sizeof(struct eth_device));
> dev->type_data = edev;
> fec = (struct fec_priv *)malloc(sizeof(*fec));
> edev->priv = fec;
> --
> 1.6.3.3
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox
mailing list