[PATCH] Fix a data abort with fec_imx

Eric Benard eric at eukrea.com
Mon Jan 11 09:32:15 EST 2010

From: Eric Benard <ebenard at 1720eb.(none)>

edev was allocated using malloc. On one board (NOR boot), we met data abort
in eth_register (at dev_add_param(dev, &edev->param_ip);).
Allocating edev with xzalloc (as in several other drivers) fixed the problem.

Signed-off-by: Eric Benard <eric at eukrea.com>
 drivers/net/fec_imx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/fec_imx.c b/drivers/net/fec_imx.c
index 4893291..49140e7 100644
--- a/drivers/net/fec_imx.c
+++ b/drivers/net/fec_imx.c
@@ -542,7 +542,7 @@ static int fec_probe(struct device_d *dev)
-        edev = (struct eth_device *)malloc(sizeof(struct eth_device));
+        edev = (struct eth_device *)xzalloc(sizeof(struct eth_device));
         dev->type_data = edev;
 	fec = (struct fec_priv *)malloc(sizeof(*fec));
         edev->priv = fec;

More information about the barebox mailing list