struct usbatm_control

Roman Kagan rkagan at
Tue May 3 09:33:32 EDT 2005

On Mon, May 02, 2005 at 09:48:25AM +0200, Duncan Sands wrote:
> Hi Roman, is this change correct?
>  struct usbatm_control {
> -       struct atm_skb_data atm_data;
> ...
> +       struct atm_vcc *vcc;
> ...
>  };
> The ATM layer uses the skb->cb too, putting a
> struct atm_skb_data there.  I didn't want to overwrite
> any of that, which is why I put a struct atm_skb_data
> at the start of struct usbatm_control.  Was I being too
> conservative - are you sure that we're not going to
> stomp on ATM layer info now?

Well, I thought once the ATM layer let the skb go, we could do whatever
we wanted to the control block.  And it did work somehow :)  But I'm
fine with reverting it, that was a nano-optimization not particularly
worth while.


More information about the Usbatm mailing list