[PATCH v1] "Reset registers to enhance robustness."

[Xiang W]

在 2024-05-29星期三的 15:37 +0800，Pope B.Lei写道：
> Signed-off-by: Pope B.Lei <popeblei at gmail.com>
> ---
> V1: If the registers are not initialized, they may remain in an x-state in certain DV verification environments due to the lack of written
> values, causing the x-state to propagate during the boot process. Adding register initialization enhances robustness.

In DV system, all registers should be written to prevent the existence of registers
in x-state state. _reset_regs cannot write all registers for parameter passing. If
all registers are written, it will affect the function of opensbi.

So I don't think it's a good way to stop a register from having x-state state.

Regards,
Xiang W

>  firmware/fw_base.S | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/firmware/fw_base.S b/firmware/fw_base.S
> index b950c0b..10889a9 100644
> --- a/firmware/fw_base.S
> +++ b/firmware/fw_base.S
> @@ -36,6 +36,8 @@
>  	.globl _start
>  	.globl _start_warm
>  _start:
> +	/* Reset registers to enhance robustness. */
> +	call	_reset_regs
>  	/* Find preferred boot HART id */
>  	MOV_3R	s0, a0, s1, a1, s2, a2
>  	call	fw_boot_hart
> -- 
> 2.35.2.windows.1
> 
>