[PATCH] Allow specifying server in configuration file

[David Woodhouse]

On Tue, 2018-04-03 at 17:24 -0500, Daniel Lenski wrote:
> On Tue, Apr 3, 2018 at 3:37 PM, Max Rees <maxcrees at me.com> wrote:
> > 
> > On Apr 03 01:29 PM, Daniel Lenski wrote:
> > > 
> > > I think you should also check for the converse case of a
> > > *double-specified* server (where the user specifies --server and
> > > an
> > > argument with no option).
> > > It'd be something like (optind < argc && vpninfo->hostname).
>
> > What should be the behavior in this situation? An error message or
> > should it accept one or the other as the server to use?
>
> I'd say it should be an error ("explicit is better than implicit"),
> but BDFL David Woodhouse should tell me if I'm wrong. :-D

I'd probably be inclined to suggest we should accept whatever comes
last. We don't reject multiple '--server xxx' options, do we? It allows
the value in the config file to be overridden on the command line.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5213 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20180404/e8ed5705/attachment.bin>