[PATCH] Allow specifying server in configuration file

Daniel Lenski dlenski at gmail.com
Tue Apr 3 15:24:59 PDT 2018


On Tue, Apr 3, 2018 at 3:37 PM, Max Rees <maxcrees at me.com> wrote:
> On Apr 03 01:29 PM, Daniel Lenski wrote:
>> I think you should also check for the converse case of a
>> *double-specified* server (where the user specifies --server and an
>> argument with no option).
>> It'd be something like (optind < argc && vpninfo->hostname).
>
> What should be the behavior in this situation? An error message or
> should it accept one or the other as the server to use?

I'd say it should be an error ("explicit is better than implicit"),
but BDFL David Woodhouse should tell me if I'm wrong. :-D

Dan



More information about the openconnect-devel mailing list