[PATCH] avoid multiple "domain" entries in resolv.conf

David Woodhouse dwmw2 at infradead.org
Thu Aug 25 08:07:41 PDT 2016


> +	DOMAINS=$CISCO_DEF_DOMAIN

If $CISCO_DEF_DOMAIN contains spaces (e.g. 'foo bar'), this becomes
 DOMAINS=foo bar
...resulting in:
 bar: command not found

It needs quotes around it, surely?

> -				#if [ -z "$CISCO_DEF_DOMAIN_ORIG" ]; then
> +				#if [ -z "$$CISCO_DEF_DOMAIN" ]; then

Something went wrong with your search/replace there (and in a few more places).

Other than that, looks good. Thanks for the careful analysis.

-- 
dwmw2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5760 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20160825/56462d4a/attachment-0001.bin>


More information about the openconnect-devel mailing list