[PATCH] avoid multiple "domain" entries in resolv.conf

Corey Hickey bugfood-ml at fatooh.org
Tue Aug 23 12:18:14 PDT 2016

On 2016-08-15 10:50, Corey Hickey wrote:
> On 2016-08-10 14:05, Raghavendra Prabhu wrote:
>> Hi,
>> Thanks for the patch.
>> I have following questions regarding this patch:
>>   a) In the patch I see that it is handling only for
>> modify_resolvconf_generic. What about other modify_*. This issue
>> affects them as well. (In my case it uses modify_resolvconf_manager).
>>   b)  Instead of choosing only the first domain, is it not possible to
>> use 'search' followed by the list of domains.   At least this is how I
>> updated the script to do, and that works fine.
>>             i) At least, that is how the modify_resolvconf_generic
>> seems to be operating when it parses the backup resolv.conf for
>> 'search' entries first, if present, appends to them, if not uses the
>> 'domain' keyword.
> Hmm. Your comments lead me to realize this is more complicated than I
> had thought.


> The following patch is a more intrusive rewrite, but should be much
> better. Please let me know if I am missing something or making an
> incorrect assumption.

Hi David,

Sorry to bug you, but do you have a comment on the patch I sent?


More information about the openconnect-devel mailing list