[PATCH 1/2] android/openconnect: add ability to build openconnect within android.

David Woodhouse dwmw2 at infradead.org
Fri Jul 15 13:27:04 EDT 2011


On Fri, 2011-07-15 at 10:01 -0400, Jason wrote:
> > You remove the <sys/syslog.h> inclusion but *don't* remove the actual
> > calls to syslog() ? How does *that* work?
> 
> By not calling openconnect with '--syslog' ;-)  My mistake.  It builds,
> though.  I'll dig deeper.
> 
> > Hm, should I be including <syslog.h> instead of <sys/syslog.h> ?
> 
> Whichever you prefer.  Android build system/bionic is unique to say the
> least.  I wouldn't make any special changes just for it. 

I think that <syslog.h> is correct.

I see that back in the mists of time, I already *added* <syslog.h> to
make it build on Solaris. I probably should have made it include that
*instead* of <sys/syslog.h>, rather than in addition.

I've removed the non-standard <sys/syslog.h> inclusion now. I think it
should work everywhere.

-- 
dwmw2




More information about the openconnect-devel mailing list