[PATCH v3 04/11] ARM: bcm2835: dt: add bindings for shared interrupt properties

[Martin Sperl]

> On 08.03.2016, at 00:24, Eric Anholt <eric at anholt.net> wrote:
> 
> kernel at martin.sperl.org writes:
> 
>> From: Martin Sperl <kernel at martin.sperl.org>
>> 
>> Add binding documentation for the new shared interrupt properties:
>> * brcm,dma-channel-shared-mask
>> * brcm,dma-shared-irq-index
>> 
>> Signed-off-by: Martin Sperl <kernel at martin.sperl.org>
>> ---
>> Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt | 6 ++++++
>> 1 file changed, 6 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt
>> index 1396078..f9e84ee 100644
>> --- a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt
>> +++ b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt
>> @@ -17,6 +17,10 @@ Required properties:
>> - brcm,dma-channel-mask: Bit mask representing the channels
>> 			 not used by the firmware in ascending order,
>> 			 i.e. first channel corresponds to LSB.
>> +- brcm,dma-channel-shared-mask: Bit mask representing the channels
>> +				that use a shared interrupt
>> +- brcm,dma-shared-irq-index: index of which of the interrupts mentioned
>> +			     above is the shared interrupt
> 
> This should be under "Optional properties" since there are appropriate
> defaults for the only compatible string listed.

Well - IMO it is actually required and the defaults are only for backwards
compatibility with older device-trees, but that is easy to change…
> 
> I still don't think exposing this in the DT is necessary (it's hardware
> block internals), but I'm not writing the code so I'm fine with it
Actually this was a request by Vinod to make this configurable via the
device-tree.

> either way, really.  Regardless, it would be really good to get the
> slave_sg part of the series in, which is really important for the
> platform.
Yes, then we can bring the DMA implementations for mmc/sdhost forward.

Martin