[PATCH 2/3] ARM: bcm2835: Add the Raspberry Pi firmware driver

[Jassi Brar]

On Wed, Apr 29, 2015 at 7:28 AM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 04/27/2015 05:14 PM, Eric Anholt wrote:
>
>> +     firmware->chan = mbox_request_channel(&firmware->cl, 0);
>> +     if (IS_ERR(firmware->chan)) {
>> +             ret = PTR_ERR(firmware->chan);
>> +             /* An -EBUSY from the core means it couldn't find our
>> +              * channel, because the mailbox driver hadn't
>> +              * registered yet.
>> +              */
>> +             if (ret == -EBUSY)
>> +                     ret = -EPROBE_DEFER;
>> +             else
>> +                     dev_err(dev, "Failed to get mbox channel: %d\n", ret);
>
> I would have hoped that mbox_request_channel() returned -EPROBE_DEFER
> itself. It really should...
>
Yes, it should. Let me look into it.

Thanks.