[PATCH] Add DT support for PinBall board

Stephen Warren swarren at wwwdotorg.org
Fri Apr 3 07:27:56 PDT 2015


On 04/03/2015 07:39 AM, Grégory Hermant wrote:
> Hi All,
> RPi Foundation's kernel repository not opened to include the support of custom boards based on CM while the support of RPi HATs to the RPi Foundation's kernel repository is welcome.
> Did i miss something ?

I suspect the issue is simply that you didn't Cc any specific person on 
the patch, so nobody read it.

I'm not sure of the process for contributing to the RPi Foundation's 
kernel; a github pull request might be more typical?

> Grégory
>
> On 28/03/2015 14:58, Grégory Hermant wrote:
>> Hi Stephen,
>>
>> On 28/03/2015 05:02, Stephen Warren wrote:
>>> On 03/24/2015 02:55 AM, Gregory Hermant wrote:
>>>
>>> An explanation of what the board is would be nice.
>>>
>>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>>
>>>>   dtb-$(CONFIG_BCM2708_DT) += bcm2708-rpi-b.dtb
>>>>   dtb-$(CONFIG_BCM2708_DT) += bcm2708-rpi-b-plus.dtb
>>>> +dtb-$(CONFIG_BCM2708_DT) += bcm2708-pinball.dtb
>>>>   dtb-$(CONFIG_BCM2709_DT) += bcm2709-rpi-2-b.dtb
>>>
>>> Alphabetical order would be nice.
>>>
>>>> diff --git a/arch/arm/boot/dts/bcm2708-pinball.dts b/arch/arm/boot/dts/bcm2708-pinball.dts
>>>
>>>> +/include/ "bcm2708.dtsi"
>>>
>>> That file doesn't exist in the upstream kernel. Are you sending this for
>>> inclusion in the RPi Foundation's kernel, or the upstream kernel?
>>>
>>> It'd help if you CC'd whoever you want to apply this. If this is a patch
>>> for upstream, you'd also want to CC some mailing lists with wider
>>> distribution, such as the ARM kernel mailing list.
>>>
>>> I assume this is a patch for the RPi Foundation's kernel given the DT
>>> name above, and the __overrides__ node at the end, so I won't review the
>>> balance of the patch.
>>>
>> My first goal is to submit a patch for the pinball board to the RPi Foundation's kernel (as a lot of distributions use this kernel)
>> and then submit a version to the upstream kernel (because at the end everybody should use the upstream kernel).
>> I understand that the patch intended to the RPi Foundation's kernel is not best solution but from a practical point of view i think it can be
>> interesting for the end users.
>> Thanks for your comments.
>> Grégory
>>
>> _______________________________________________
>> linux-rpi-kernel mailing list
>> linux-rpi-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel
>>
>>
>>
>> _______________________________________________
>> linux-rpi-kernel mailing list
>> linux-rpi-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel




More information about the linux-rpi-kernel mailing list