[PATCH 1/2] PCI: dwc: Add L1ss context to ltssm_status of debugfs

Bjorn Helgaas helgaas at kernel.org
Thu Dec 11 08:29:52 PST 2025


On Tue, Nov 25, 2025 at 09:53:51AM +0800, Shawn Lin wrote:
> dwc core couldn't distinguish ltssm status among L1.0, L1.1 and L1.2.
> But the variant driver may implement additional register to tell them
> apart. So this patch adds two pseudo definitions for variant drivers to
> transltae their internal L1 substates for debugfs to show.

s/L1ss/L1 Substates/ in subject
s/ltssm/LTSSM/
s/transltae/translate/

Use imperative mood:
  https://chris.beams.io/posts/git-commit/
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/maintainer-tip.rst?id=v6.14#n134

In this case, imperative mood means:

  s/So this patch adds/Add/

> +++ b/drivers/pci/controller/dwc/pcie-designware.h
> @@ -380,6 +380,10 @@ enum dw_pcie_ltssm {
>  	DW_PCIE_LTSSM_RCVRY_EQ2 = 0x22,
>  	DW_PCIE_LTSSM_RCVRY_EQ3 = 0x23,
>  
> +	/* Variant drivers provide pseudo L1 substates from get_ltssm()*/

Add space before "*/".

> +	DW_PCIE_LTSSM_L1_1 = 0x141,
> +	DW_PCIE_LTSSM_L1_2 = 0x142,
> +
>  	DW_PCIE_LTSSM_UNKNOWN = 0xFFFFFFFF,
>  };
>  
> -- 
> 2.43.0
> 
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip



More information about the Linux-rockchip mailing list