[RESEND2 PATCH v5 0/3] Add Radxa CM5 module and IO board dts

[FUKAUMI Naoki]

On 12/3/25 17:45, FUKAUMI Naoki wrote:
> Hi Jimmy,
> 
> On 12/3/25 14:42, Jimmy Hon wrote:
>> On Tue, Dec 2, 2025 at 4:16 AM FUKAUMI Naoki <naoki at radxa.com> wrote:
>>>
>>> Hi all,
>>>
>>> I sincerely hope the following will be helpful in your review.
>>>    https://github.com/RadxaNaoki/linux/blob/cm5-io-v999-20251201/ 
>>> arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi
>>>    https://github.com/RadxaNaoki/linux/blob/cm5-io-v999-20251201/ 
>>> arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
>> Could you elaborate on why you're linking to the "v999" branch? The
> 
> When you review something (e.g., v5), you might find it helpful to refer 
> to another similar thing (e.g., v999).
> 
>> content of that branch doesn't match the contents of this patch series
>> (i.e. RESEND 2 of v5). The "v5" branch looks closer to this
>> submission.
>> https://github.com/RadxaNaoki/linux/blob/cm5-io-v5-20251201
>>
>> Comments on the "v999" branch...it does have the improvements:
> 
> You do not need to review v999, as it is not part of this patch series 
> (it is Joseph's work). Please only review v5 and subsequent versions.

"it" before "is Joseph's work" was unclear... I meant "this patch series 
is Joseph's work".

>> - that allows the usage of the Radxa eMMC to uSD adapter
>> - defines the gmac1 in the SoM dtsi, but only enables the gmac1 in the
>> IO board's dts.
> 
> Thanks anyway.

I'll reflect your suggestion in v6.
  https://lore.kernel.org/linux-rockchip/CALWfF7+G6MRvuSm8a-a0KcPduXz=sYsJT0bB300rAqmtt2w-cg@mail.gmail.com/

> Best regards,
> 
> -- 
> FUKAUMI Naoki
> Radxa Computer (Shenzhen) Co., Ltd.
> 
>>>
>>> Best regards,
>>>
>>> -- 
>>> FUKAUMI Naoki
>>> Radxa Computer (Shenzhen) Co., Ltd.
>>
>> Jimmy
>>
>