[PATCH 2/3 v3] dt-bindings: arm: rockchip: Add Xunlong Orange Pi 5 Max

[Jimmy Hon]

On Mon, Nov 11, 2024 at 2:57 PM Rob Herring (Arm) <robh at kernel.org> wrote:
>
>
> On Sun, 10 Nov 2024 22:53:25 -0600, Jimmy Hon wrote:
> > Add devicetree binding for the Xunlong Orange Pi 5 Max board.
> >
> > The Orange Pi 5 Max is a single board computer powered by the Rockchip
> > RK3588 similar to the Orange Pi 5 Plus.
> >
> > Signed-off-by: Jimmy Hon <honyuenkwun at gmail.com>
> > ---
> >  Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
>
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.
This v3 version is now sharing a base dtsi with the Orange Pi 5 Plus.
So it's not a separate entry in the dt-bindings like it was in v2.

I'm eager to hear from the Orange Pi 5 Plus maintainer if this
approach is good, or if the boards are considered two divergent and
trying to share a dtsi is going to cause more headaches when enabling
features that are unique to the Orange Pi 5 Plus.

In this case, it's not as similar as the NanoPi R6C vs R6S or the
Orange Pi 5 vs Pi 5B.

So if we decide to use the common approach, I can use Conor's Ack. But
if we decide to use the separate approach, I can use your Ack from v2.

>
> Missing tags:
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>
>
>

Jimmy