[PATCH] arm64: dts: rockchip: radxa-e25: fix typo in vcc3v3-pi6c-05-regulator

FUKAUMI Naoki naoki at radxa.com
Fri Apr 21 16:14:19 PDT 2023


hi,

On 4/21/23 20:48, Heiko Stuebner wrote:
> Hi,
> 
> Am Donnerstag, 20. April 2023, 12:15:55 CEST schrieb FUKAUMI Naoki:
>> "gpios" should be "gpio"
> 
> I don't see this.
> 
> The fixed-regulator binding does specify both "gpios" and "gpio" as valid.
> And the code also tries both [0].
> 
> So this change really isn't necessary.

I see. it seems I referred old document... sorry for bothering you.

--
FUKAUMI Naoki

> Heiko
> 
> [0] https://elixir.bootlin.com/linux/latest/source/drivers/gpio/gpiolib.h#L86
> 
>> Fixes: 2bf2f4d9f673 ("arm64: dts: rockchip: Add Radxa CM3I E25")
>> Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>
>> ---
>>   arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
>> index 63c4bd873188..bde43c4a5bb1 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
>> @@ -89,7 +89,7 @@ vcc3v3_pcie30x1: vcc3v3-pcie30x1-regulator {
>>   	vcc3v3_pi6c_05: vcc3v3-pi6c-05-regulator {
>>   		compatible = "regulator-fixed";
>>   		enable-active-high;
>> -		gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
>> +		gpio = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
>>   		pinctrl-names = "default";
>>   		pinctrl-0 = <&pcie_enable_h>;
>>   		regulator-name = "vcc3v3_pcie";
>>
> 
> 
> 
> 
> 



More information about the Linux-rockchip mailing list