[PATCH 1/3] mtd: spi-nor: add rockchip serial flash controller driver

[Pratyush Yadav]

On 26/05/21 01:16PM, Chris Morgan wrote:
> From: Chris Morgan <macromorgan at hotmail.com>
> 
> Add the rockchip serial flash controller (SFC) driver.
> 
> Signed-off-by: Chris Morgan <macromorgan at hotmail.com>
> ---
>  drivers/mtd/spi-nor/controllers/Kconfig       |   7 +
>  drivers/mtd/spi-nor/controllers/Makefile      |   1 +
>  .../mtd/spi-nor/controllers/rockchip-sfc.c    | 944 ++++++++++++++++++

NACK. Please don't add controller drivers here. Instead use the SPI MEM 
(drivers/spi/spi-mem.c) framework and put the drivers in drivers/spi/. 
See the history for drivers/spi/spi-cadence-quadspi.c for an example 
conversion. I recall mentioning this on IRC as well, but maybe my memory 
misleads me.

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.