[PATCH 1/2] regulator: rk808: add dvs support
Doug Anderson
dianders at chromium.org
Tue Dec 9 16:41:40 PST 2014
Chris,
On Tue, Dec 9, 2014 at 5:51 AM, Chris Zhong <zyw at rock-chips.com> wrote:
> + /* dvsok pin would be pull down when dvs1/2 pin changed, and
> + * it would be pull up once the voltage regulate complete.
> + * No need to wait dvsok signal when voltage falling.
> + */
A tiny nit that I think standard multiline commenting style should
make the above:
+ /*
+ * dvsok pin would be pull down when dvs1/2 pin changed, and
+ * it would be pull up once the voltage regulate complete.
+ * No need to wait dvsok signal when voltage falling.
+ */
...but I'll leave it up to broonie@ if he cares...
Given that I've privately reviewed an earlier version of this before
you sent it up, it's not surprising that I have no other comments, so:
Reviewed-by: Doug Anderson <dianders at chromium.org>
:)
-Doug
More information about the Linux-rockchip
mailing list