[PATCH v6 00/15] Add basic clocks and resets for JHB100 SoC

Changhuang Liang changhuang.liang at starfivetech.com
Mon Oct 12 22:15:04 PDT 2026


Hi, Jerome

> On 2026-10-12 20:03 +0100, Conor Dooley wrote:
> > On Mon, Oct 12, 2026 at 12:21:47PM +0200, Jerome Brunet wrote:
> > > > The JHB100 SoC includes CRG (Clock and Reset Generator) for
> > > > multiple
> > > > subsystems:
> > >
> > > Nothing really forces you to send them all together.
> > >
> > > In the future, could you try to send one CRG driver at a time ?
> > >
> > > It is fine to send big RFC to give context but after that, if you
> > > can make you series smaller, it is generally a good idea to do so.
> > >
> > > This helps us iterate on the series faster and then you can fold our
> > > feedback in following series (instead of repeating the same comments
> > > on multiple instances of the same thing) Thanks.
> > >
> >
> > > Also your series does not apply on clk-next or -rc1 and no
> > > pre-requisite are mentioned in this cover letter. Consider using b4
> > > to point out your pre-requisite if any
> >
> > The dep should be the PR I sent to Brian, but I suspect what's
> > happened here is that the MAINTAINERS parts of those patches (which I
> > had dropped because they were all conflicting with my tree) didn't get
> > reabsorbed into this series. Very annoying for review of course, even
> > if it's a non-functional conflict. Of course rebase on top of clk-next
> > would've highlighted that to the submitter!
> 
> Yes it was only the MAINTAINERS file which I did rebase to check if the rest
> applied correctly.

In subsequent versions, I will pay attention to conflicts with this file.

Best Regards,
Changhuang



More information about the linux-riscv mailing list