[PATCH 4/4] riscv: dts: thead: th1520-lichee-pi-4a: Cleanup with dt-check-style

Kanak Shilledar kanak.shilledar at axis.com
Fri Oct 2 06:43:36 PDT 2026


Fix warnings thrown by krzk's recent updates to the dt-check-style
tool when run with strict mode. Fix the following warnings:

	thead/th1520-lichee-pi-4a.dts:161: [property-order] property 'pinctrl-names' must be placed after 'pinctrl-0'
	thead/th1520-lichee-pi-4a.dts:163: [required-blank-lines] "status" must be preceded by a blank line
	thead/th1520-lichee-pi-4a.dts:217: [child-name-order] child node 'rx-pins' out of name order

After this patch, there are no more warnings thrown. Fix these
warnings to make the file more readable and maintainable along with
that to make it more compliant with the devicetree specifications.

Signed-off-by: Kanak Shilledar <kanak.shilledar at axis.com>
---
 arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts | 90 ++++++++++++-----------
 1 file changed, 47 insertions(+), 43 deletions(-)

diff --git a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
index 1eb575aa9a74f..5908b21d558d4 100644
--- a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
+++ b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
@@ -41,10 +41,13 @@ hdmi_con_in: endpoint {
 		};
 	};
 
-	wifi_pwrseq: wifi-pwrseq {
-		compatible = "mmc-pwrseq-simple";
-		reset-gpios = <&ioexp2 4 GPIO_ACTIVE_LOW>;
-		post-power-on-delay-ms = <200>;
+	fan: pwm-fan {
+		compatible = "pwm-fan";
+		pinctrl-0 = <&fan_pins>;
+		pinctrl-names = "default";
+		#cooling-cells = <2>;
+		pwms = <&pwm 1 10000000 0>;
+		cooling-levels = <0 66 196 255>;
 	};
 
 	thermal-zones {
@@ -53,6 +56,23 @@ cpu-thermal {
 			polling-delay-passive = <1000>;
 			thermal-sensors = <&pvt 0>;
 
+			cooling-maps {
+				map-active-0 {
+					cooling-device = <&fan 1 1>;
+					trip = <&fan_config0>;
+				};
+
+				map-active-1 {
+					cooling-device = <&fan 2 2>;
+					trip = <&fan_config1>;
+				};
+
+				map-active-2 {
+					cooling-device = <&fan 3 3>;
+					trip = <&fan_config2>;
+				};
+			};
+
 			trips {
 				fan_config0: fan-trip0 {
 					temperature = <39000>;
@@ -72,35 +92,14 @@ fan_config2: fan-trip2 {
 					type = "active";
 				};
 			};
-
-			cooling-maps {
-				map-active-0 {
-					cooling-device = <&fan 1 1>;
-					trip = <&fan_config0>;
-				};
-
-				map-active-1 {
-					cooling-device = <&fan 2 2>;
-					trip = <&fan_config1>;
-				};
-
-				map-active-2 {
-					cooling-device = <&fan 3 3>;
-					trip = <&fan_config2>;
-				};
-			};
 		};
 	};
 
-	fan: pwm-fan {
-		pinctrl-names = "default";
-		pinctrl-0 = <&fan_pins>;
-		compatible = "pwm-fan";
-		#cooling-cells = <2>;
-		pwms = <&pwm 1 10000000 0>;
-		cooling-levels = <0 66 196 255>;
+	wifi_pwrseq: wifi-pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		reset-gpios = <&ioexp2 4 GPIO_ACTIVE_LOW>;
+		post-power-on-delay-ms = <200>;
 	};
-
 };
 
 &dpu {
@@ -119,8 +118,9 @@ hdmi_out_con: endpoint {
 
 &i2c0 {
 	clock-frequency = <400000>;
-	pinctrl-names = "default";
 	pinctrl-0 = <&i2c0_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 
 	ioexp1: gpio at 18 {
@@ -136,8 +136,9 @@ ioexp1: gpio at 18 {
 
 &i2c1 {
 	clock-frequency = <400000>;
-	pinctrl-names = "default";
 	pinctrl-0 = <&i2c1_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 
 	ioexp2: gpio at 18 {
@@ -158,8 +159,9 @@ ioexp2: gpio at 18 {
 
 &i2c3 {
 	clock-frequency = <400000>;
-	pinctrl-names = "default";
 	pinctrl-0 = <&i2c3_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 
 	ioexp3: gpio at 18 {
@@ -204,16 +206,6 @@ i2c-pins {
 	};
 
 	uart0_pins: uart0-0 {
-		tx-pins {
-			pins = "UART0_TXD";
-			function = "uart";
-			bias-disable;
-			drive-strength = <3>;
-			input-disable;
-			input-schmitt-disable;
-			slew-rate = <0>;
-		};
-
 		rx-pins {
 			pins = "UART0_RXD";
 			function = "uart";
@@ -223,6 +215,16 @@ rx-pins {
 			input-schmitt-enable;
 			slew-rate = <0>;
 		};
+
+		tx-pins {
+			pins = "UART0_TXD";
+			function = "uart";
+			bias-disable;
+			drive-strength = <3>;
+			input-disable;
+			input-schmitt-disable;
+			slew-rate = <0>;
+		};
 	};
 };
 
@@ -261,11 +263,13 @@ &sdio1 {
 	keep-power-in-suspend;
 	mmc-pwrseq = <&wifi_pwrseq>;
 	non-removable;
+
 	status = "okay";
 };
 
 &uart0 {
-	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 };

-- 
2.43.0




More information about the linux-riscv mailing list