[PATCH 03/25] dt-bindings: reset: add Metanoia MT2824

Krzysztof Kozlowski krzk at kernel.org
Fri Nov 6 03:19:22 PST 2026


On 06/11/2026 10:30, Benoît Monin wrote:
> +  - compatible
> +  - reg
> +  - "#reset-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    rst: rst-controller at 1000000c {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).

Also drop unused label.

> +        compatible = "metanoia,mt2824-reset";
> +        reg = <0x1000000c 0x4>;

I don't think one word of registers is a device. You split one device
into several fake subparts, that's not correct.


Best regards,
Krzysztof



More information about the linux-riscv mailing list