[PATCH v2 1/3] RISC-V: pi: Force hidden visibility for all symbol references

Alexandre Ghiti alexghiti at rivosinc.com
Fri Jun 28 02:21:33 PDT 2024


Hi Jesse,

On Thu, Jun 27, 2024 at 12:35 PM Conor Dooley
<conor.dooley at microchip.com> wrote:
>
> On Wed, Jun 26, 2024 at 01:16:50PM -0400, Jesse Taube wrote:
> > Eliminate all GOT entries in the .pi section, by forcing hidden
> > visibility for all symbol references, which informs the compiler that
> > such references will be resolved at link time without the need for
> > allocating GOT entries.
> >
> > Include linux/hidden.h in Makefile, like arm64, for the
> > hidden visibility attribute.
> >
> > Signed-off-by: Jesse Taube <jesse at rivosinc.com>
>
> Did you forget to add --cover-letter to your format-patch incantation?

I admittedly don't understand all the details but it makes the GOT
entry disappear and arm64 uses it too, so:

Reviewed-by: Alexandre Ghiti <alexghiti at rivosinc.com>

Thanks,

Alex



More information about the linux-riscv mailing list