[PATCH v4] nvme: change nvme_ns_has_pi() to nvme_ns_supports_pract()
Keith Busch
kbusch at kernel.org
Wed Oct 23 06:14:20 PDT 2024
On Wed, Oct 23, 2024 at 05:45:54AM -0700, Christoph Hellwig wrote:
> On Wed, Oct 23, 2024 at 07:08:36PM +0900, Tokunori Ikegami wrote:
> > The PI is the first bytes or last bytes of the metadata.
> > So its size is not equal to the metadata size only but below also.
> > Then fix the function to check PI size if metadata size or below.
>
> So basically what the patch does is to make PRACT work for PI where
> the metadata size is bigger than the PI tuple size, right? Maybe state
> that clearly and put less emphasis on the mechanics of the change.
You can't just have a patch declare that PRACT works this way. The spec
says it only works if ms == PI tuple size, otherwise it doesn't do
anything.
More information about the Linux-nvme
mailing list