[PATCH v4] nvme: change nvme_ns_has_pi() to nvme_ns_supports_pract()

Christoph Hellwig hch at infradead.org
Wed Oct 23 05:45:54 PDT 2024


On Wed, Oct 23, 2024 at 07:08:36PM +0900, Tokunori Ikegami wrote:
> The PI is the first bytes or last bytes of the metadata.
> So its size is not equal to the metadata size only but below also.
> Then fix the function to check PI size if metadata size or below.

So basically what the patch does is to make PRACT work for PI where
the metadata size is bigger than the PI tuple size, right?  Maybe state
that clearly and put less emphasis on the mechanics of the change.

>  		 * The current fabrics transport drivers support namespace
> -		 * metadata formats only if nvme_ns_has_pi() returns true.
> +		 * metadata formats only if nvme_ns_supports_pract() returns true.

Pleae stick to 80 character lines.  Also a few more offenders below.




More information about the Linux-nvme mailing list