[PATCH v2 1/1] nvme: disable CC.CRIME (NVME_CC_CRIME)

[Greg Joyce]

On Wed, 2024-10-09 at 16:04 -0600, Keith Busch wrote:
> On Mon, Oct 07, 2024 at 02:33:24PM -0500, gjoyce at linux.ibm.com wrote:
> > +	/*
> > +	 * Setting CRIME results in CSTS.RDY before the media is
> > ready. This
> > +	 * make it possible for media related commands to return
> > the error
> > +	 * NVME_SC_ADMIN_COMMAND_MEDIA_NOT_READY. Until the driver
> > is
> > +	 * restructurade to handle retries, disable CC.CRIME.
> > +	 */
> > +	ctrl->ctrl_config &= ~NVME_CC_CRIME;
> 
> We could just delete this section entirely. Nothing else sets CRIME,
> so
> no need to explicitly clear it here. I guess it serves to provide a
> place for the explanation, I think we can remove the flag setting
> anyway.

I went back on forth on that. What I do like is that explicitly shows
that CRIME is not being set and why. But you're right, it's really more
of an elaborate comment. 

I have no problems with removing it. Would you like me to send a new
patch?

Greg