[PATCH v2 1/1] nvme: disable CC.CRIME (NVME_CC_CRIME)
Keith Busch
kbusch at kernel.org
Wed Oct 9 15:04:33 PDT 2024
On Mon, Oct 07, 2024 at 02:33:24PM -0500, gjoyce at linux.ibm.com wrote:
> + /*
> + * Setting CRIME results in CSTS.RDY before the media is ready. This
> + * make it possible for media related commands to return the error
> + * NVME_SC_ADMIN_COMMAND_MEDIA_NOT_READY. Until the driver is
> + * restructurade to handle retries, disable CC.CRIME.
> + */
> + ctrl->ctrl_config &= ~NVME_CC_CRIME;
We could just delete this section entirely. Nothing else sets CRIME, so
no need to explicitly clear it here. I guess it serves to provide a
place for the explanation, I think we can remove the flag setting
anyway.
More information about the Linux-nvme
mailing list