[PATCH v2] nvme: fix nvme_pr_* status code parsing

Weiwen Hu huweiwen at linux.alibaba.com
Fri May 31 01:50:41 PDT 2024


On Fri, May 31, 2024 at 10:16:50AM +0200, Christoph Hellwig wrote:
> On Thu, May 30, 2024 at 02:16:46PM +0800, Weiwen Hu wrote:
> > +	switch (nvme_sc & 0x7ff) {
> 
> Can you use the opportunity to add a NVME_SC_MASK symbolic
> name for the magic 0x7ff?  We should have done this earlier
> with already 5 occurrences, but better now than never.

I've already sent this in the previous patch:
[PATCH 2/3] nvme: fix status magic numbers

I chose the name NVME_SCT_SC_MASK to match the NVMe spec better



More information about the Linux-nvme mailing list